[coreboot-gerrit] Change in ...coreboot[master]: IntelFB: Add support for Intel font driver

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30182 )

Change subject: IntelFB: Add support for Intel font driver
......................................................................


Patch Set 3:

> (8 comments)
 > 
 > > Patch Set 1:
 > >
 > > (2 comments)
 > 
 > HI Patrick,
 > The use of this library will be to display message on screen once
 > display has been initialized. For example,
 > 1. We can display firmware update message to user
 > 2. We can also provide any BIOS setup option or display any
 > information
 > 
 > I don't think it'll be used to display debug message on screen but
 > rather enhance user experience.

Please update the commit message based on your comments.
There's nothing Intel specific on this driver, please move to a different folder in sec/drivers/


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70715d9c84dae2d0efa1631649ce27ea3c39e237
Gerrit-Change-Number: 30182
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Thu, 13 Dec 2018 16:27:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181213/ff05f358/attachment.html>