[coreboot-gerrit] Change in ...coreboot[master]: mainboard/google/poppy/variants/rammus: Fixed touchscreen function fa...

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30180 )

Change subject: mainboard/google/poppy/variants/rammus: Fixed touchscreen function failed on EVT FATP
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/30180/4/src/mainboard/google/poppy/variants/rammus/gpio.c 
File src/mainboard/google/poppy/variants/rammus/gpio.c:

https://review.coreboot.org/#/c/30180/4/src/mainboard/google/poppy/variants/rammus/gpio.c@218 
PS4, Line 218: touchscreen_enable
This is touchscreen operation enable, right?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30180
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86452c1445243c499aeaf931dba286db169c5628
Gerrit-Change-Number: 30180
Gerrit-PatchSet: 4
Gerrit-Owner: Kane Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Kane Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Jerry Chou <jerry_chou at pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu at pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 13 Dec 2018 14:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181213/c9eb5d3d/attachment.html>