[coreboot-gerrit] Change in ...coreboot[master]: mb/google/hatch: Enable H1 TPM support over SPI interface

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu Dec 13 14:04:17 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30210 )

Change subject: mb/google/hatch: Enable H1 TPM support over SPI interface
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/30210/1/src/mainboard/google/hatch/variants/hatch/gpio.c 
File src/mainboard/google/hatch/variants/hatch/gpio.c:

https://review.coreboot.org/#/c/30210/1/src/mainboard/google/hatch/variants/hatch/gpio.c@27 
PS1, Line 27: /* H1_PCH_INT_ODL */	PAD_CFG_GPI_APIC(GPP_C21, UP_20K, DEEP, EDGE_SINGLE, INVERT),
line over 80 characters


https://review.coreboot.org/#/c/30210/1/src/mainboard/google/hatch/variants/hatch/gpio.c@38 
PS1, Line 38: /* H1_PCH_INT_ODL */	PAD_CFG_GPI_APIC(GPP_C21, UP_20K, DEEP, EDGE_SINGLE, INVERT),
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib63a0b473f632d91745102ebd01993e8d65b9552
Gerrit-Change-Number: 30210
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 13 Dec 2018 13:04:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181213/83d752fe/attachment.html>


More information about the coreboot-gerrit mailing list