[coreboot-gerrit] Change in ...coreboot[master]: siemens/mc_apl4: Enable LVDS Display on mc_apl4

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30204 )

Change subject: siemens/mc_apl4: Enable LVDS Display on mc_apl4
......................................................................


Patch Set 2:

(5 comments)

https://review.coreboot.org/#/c/30204/1/src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h 
File src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h:

https://review.coreboot.org/#/c/30204/1/src/mainboard/siemens/mc_apl1/variants/mc_apl4/include/variant/ptn3460.h@4 
PS1, Line 4: 2018
> 2018
Done


https://review.coreboot.org/#/c/30204/1/src/mainboard/siemens/mc_apl1/variants/mc_apl4/ptn3460.c 
File src/mainboard/siemens/mc_apl1/variants/mc_apl4/ptn3460.c:

https://review.coreboot.org/#/c/30204/1/src/mainboard/siemens/mc_apl1/variants/mc_apl4/ptn3460.c@4 
PS1, Line 4: 2018
> 2018
Done


https://review.coreboot.org/#/c/30204/1/src/mainboard/siemens/mc_apl1/variants/mc_apl4/ptn3460.c@21 
PS1, Line 21: *
> just one
Done


https://review.coreboot.org/#/c/30204/1/src/mainboard/siemens/mc_apl1/variants/mc_apl4/ptn3460.c@116 
PS1, Line 116: *
> just one
Done


https://review.coreboot.org/#/c/30204/1/src/mainboard/siemens/mc_apl1/variants/mc_apl4/ptn3460.c@149 
PS1, Line 149: *
> same
Done



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ccf5398f16831db321eba846d6b041daadf31dd
Gerrit-Change-Number: 30204
Gerrit-PatchSet: 2
Gerrit-Owner: uwe poeche <uwe.poeche at siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: uwe poeche <uwe.poeche at siemens.com>
Gerrit-Comment-Date: Thu, 13 Dec 2018 10:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181213/b88e6ad5/attachment.html>