[coreboot-gerrit] Change in ...coreboot[master]: siemens/mc_apl4: Add GPIO configuration

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30128 )

Change subject: siemens/mc_apl4: Add GPIO configuration
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/30128/5/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c 
File src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c:

https://review.coreboot.org/#/c/30128/5/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c@224 
PS5, Line 224: ,/*
> , tab /*  ?
Is possible for this line but not for the next one without violating the 80 character rule. To make this block of comments look similar as they belong to the same logical unit I would prefer to not add the TAB here. Any objections?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30128
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia69603f42c57c1cc682550b8eeeab42fbac27563
Gerrit-Change-Number: 30128
Gerrit-PatchSet: 5
Gerrit-Owner: uwe poeche <uwe.poeche at siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: uwe poeche <uwe.poeche at siemens.com>
Gerrit-CC: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Comment-Date: Thu, 13 Dec 2018 09:55:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181213/5d4d27a5/attachment.html>