[coreboot-gerrit] Change in ...coreboot[master]: IntelFB: Add support for Intel font driver

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30182 )

Change subject: IntelFB: Add support for Intel font driver
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/30182/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30182/1//COMMIT_MSG@10 
PS1, Line 10: Framebuffer during BIOS boot to display boot message/update messages.
firmware boot

I don't see how it would be that useful.
Please give a few more examples.

Graphics should be initialized at BS_DEV_INIT.
After BS_DEV_INIT you only lock registers and write tables.
Nothing that is expected to fail or generate that much verbose output.
All the magic already has been done.


https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/font8x16.c 
File src/drivers/intel/fb/font8x16.c:

https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/font8x16.c@18 
PS1, Line 18:  *   documentation and/or other materials provided with the distribution.
is this license compatible to GPLv2 ?
Please explain why you think so.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30182
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70715d9c84dae2d0efa1631649ce27ea3c39e237
Gerrit-Change-Number: 30182
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Wed, 12 Dec 2018 13:20:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181212/c54ea8dd/attachment.html>