[coreboot-gerrit] Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 )

Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30178/2/src/mainboard/google/poppy/variants/nami/mainboard.c 
File src/mainboard/google/poppy/variants/nami/mainboard.c:

https://review.coreboot.org/#/c/30178/2/src/mainboard/google/poppy/variants/nami/mainboard.c@250 
PS2, Line 250: case SKU_0_EKKO:
             : 	case SKU_1_EKKO:
             : 	case SKU_2_EKKO:
             : 	case SKU_3_EKKO:
             : 	case SKU_0_BARD:
             : 	case SKU_1_BARD:
             : 	case SKU_2_BARD:
             : 	case SKU_3_BARD:
             : 		pl2_id = PL2_ID_BARD_EKKO;
If port 5 needs to be disabled for these skus, then you will have to put this above case SKU_0_VAYNE:



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0
Gerrit-Change-Number: 30178
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo at quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo at quanta.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 12 Dec 2018 07:27:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181212/d679713c/attachment.html>