[coreboot-gerrit] Change in ...coreboot[master]: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30178 )

Change subject: mb/google/poppy/variants/nami: perform PL2 setting fro bard/ekko
......................................................................


Patch Set 1:

(18 comments)

https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c 
File src/mainboard/google/poppy/variants/nami/mainboard.c:

https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@250 
PS1, Line 250:         case SKU_0_EKKO:
code indent should use tabs where possible


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@250 
PS1, Line 250:         case SKU_0_EKKO:
please, no spaces at the start of a line


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@251 
PS1, Line 251:         case SKU_1_EKKO:
code indent should use tabs where possible


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@251 
PS1, Line 251:         case SKU_1_EKKO:
please, no spaces at the start of a line


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@252 
PS1, Line 252:         case SKU_2_EKKO:
code indent should use tabs where possible


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@252 
PS1, Line 252:         case SKU_2_EKKO:
please, no spaces at the start of a line


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@253 
PS1, Line 253:         case SKU_3_EKKO:
code indent should use tabs where possible


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@253 
PS1, Line 253:         case SKU_3_EKKO:
please, no spaces at the start of a line


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@254 
PS1, Line 254:         case SKU_0_BARD:
code indent should use tabs where possible


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@254 
PS1, Line 254:         case SKU_0_BARD:
please, no spaces at the start of a line


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@255 
PS1, Line 255:         case SKU_1_BARD:
code indent should use tabs where possible


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@255 
PS1, Line 255:         case SKU_1_BARD:
please, no spaces at the start of a line


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@256 
PS1, Line 256:         case SKU_2_BARD:
code indent should use tabs where possible


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@256 
PS1, Line 256:         case SKU_2_BARD:
please, no spaces at the start of a line


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@257 
PS1, Line 257:         case SKU_3_BARD:
code indent should use tabs where possible


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@257 
PS1, Line 257:         case SKU_3_BARD:
please, no spaces at the start of a line


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@258 
PS1, Line 258:                 pl2_id = PL2_ID_BARD_EKKO;
code indent should use tabs where possible


https://review.coreboot.org/#/c/30178/1/src/mainboard/google/poppy/variants/nami/mainboard.c@258 
PS1, Line 258:                 pl2_id = PL2_ID_BARD_EKKO;
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f9d672c4244c363a7cfb362653663a065259fc0
Gerrit-Change-Number: 30178
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo <ren.kuo at quanta.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 12 Dec 2018 07:01:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181212/219cee76/attachment.html>