[coreboot-gerrit] Change in ...coreboot[master]: arch/x86/smbios: Add SMBIOS type for QCA6174A

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30150 )

Change subject: arch/x86/smbios: Add SMBIOS type for QCA6174A
......................................................................


Patch Set 1:

(12 comments)

https://review.coreboot.org/#/c/30150/1/src/arch/x86/smbios.c 
File src/arch/x86/smbios.c:

https://review.coreboot.org/#/c/30150/1/src/arch/x86/smbios.c@479 
PS1, Line 479: 	
trailing whitespace


https://review.coreboot.org/#/c/30150/1/src/arch/x86/smbios.c@489 
PS1, Line 489: 	t->board_file_extension = smbios_add_string(t->eos, smbios_bdf_extension());
line over 80 characters


https://review.coreboot.org/#/c/30150/1/src/arch/x86/smbios.c@490 
PS1, Line 490: 	
trailing whitespace


https://review.coreboot.org/#/c/30150/1/src/arch/x86/smbios.c@778 
PS1, Line 778: 		
trailing whitespace


https://review.coreboot.org/#/c/30150/1/src/include/smbios.h 
File src/include/smbios.h:

https://review.coreboot.org/#/c/30150/1/src/include/smbios.h@207 
PS1, Line 207: 	SMBIOS_END_OF_TABLE = 127,	
trailing whitespace


https://review.coreboot.org/#/c/30150/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c 
File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:

https://review.coreboot.org/#/c/30150/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@102 
PS1, Line 102: {    
trailing whitespace


https://review.coreboot.org/#/c/30150/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@103 
PS1, Line 103:         return "BDF_GO_LIARA";
code indent should use tabs where possible


https://review.coreboot.org/#/c/30150/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@103 
PS1, Line 103:         return "BDF_GO_LIARA";
please, no spaces at the start of a line


https://review.coreboot.org/#/c/30150/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@108 
PS1, Line 108:         return 0x00;
code indent should use tabs where possible


https://review.coreboot.org/#/c/30150/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@108 
PS1, Line 108:         return 0x00;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/30150/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@113 
PS1, Line 113:         return 0x00;
code indent should use tabs where possible


https://review.coreboot.org/#/c/30150/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@113 
PS1, Line 113:         return 0x00;
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30150
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d1f84898bb4130b55508cc29fa2412ec8bad658
Gerrit-Change-Number: 30150
Gerrit-PatchSet: 1
Gerrit-Owner: Amanda Hwang <amanda_hwang at compal.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 11 Dec 2018 09:53:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181211/e01fc87c/attachment.html>