[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/lynxpoint: Remove incomplete SATA ACPI code

Tristan Corrick (Code Review) gerrit at coreboot.org
Tue Dec 11 08:44:00 CET 2018


Hello Patrick Rudolph, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/30149

to look at the new patch set (#2).

Change subject: sb/intel/lynxpoint: Remove incomplete SATA ACPI code
......................................................................

sb/intel/lynxpoint: Remove incomplete SATA ACPI code

The existing SATA ACPI code for Lynx Point implements some methods and
devices, but not completely. These methods are optional and only used in
IDE mode. The code was likely copied from bd82x6x, where it has since
been removed.

As a result, many remarks produced by iasl about unreferenced objects
are eliminated.

Tested on an ASRock H81M-HDS and an Acer C720. No issues with SATA
were observed.

Change-Id: I808a9dff7b9ba34239ffd95fa4cb9b39b10c4b62
Signed-off-by: Tristan Corrick <tristan at corrick.kiwi>
---
M src/southbridge/intel/lynxpoint/acpi/sata.asl
1 file changed, 2 insertions(+), 52 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/30149/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30149
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I808a9dff7b9ba34239ffd95fa4cb9b39b10c4b62
Gerrit-Change-Number: 30149
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181211/4418c1e6/attachment.html>


More information about the coreboot-gerrit mailing list