[coreboot-gerrit] Change in ...coreboot[master]: tint: introduce the new tint build system with checksum verification

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23856 )

Change subject: tint: introduce the new tint build system with checksum verification
......................................................................


Patch Set 8:

(15 comments)

https://review.coreboot.org/#/c/23856/8/payloads/external/tint/generate_core.sh 
File payloads/external/tint/generate_core.sh:

https://review.coreboot.org/#/c/23856/8/payloads/external/tint/generate_core.sh@38 
PS8, Line 38: 		sed -n "/^${start}/,/^${end}/{/^${start}/{p;n};{p}}" $source >> $destination
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/generate_core.sh@40 
PS8, Line 40: 		sed -n "/^${start}/,/^${end}/{/^${start}/{p;n};/^${end}/{q};{p}}" $source >> $destination
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/generate_core.sh@54 
PS8, Line 54: FUNCTIONS="please_install searchtool download compute_hash error_hash_mismatch verify_hash unpack_and_patch"
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/generate_core.sh@64 
PS8, Line 64: import_from_file $buildgcc $corescript "# Find all the required tools" "# Allow" last_line_disabled || exit "$?"
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/generate_core.sh@70 
PS8, Line 70: import_from_file $buildgcc $corescript "if \[ \"\$HALT_FOR_TOOLS" "fi" || exit "$?"
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/generate_core.sh@86 
PS8, Line 86: sed -i -e "s/\tknown_hash=\"\$(get_known_hash.*/\tknown_hash=\"\$2\"/g" $corescript
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/generate_core.sh@95 
PS8, Line 95: # Insert prepare_${package} function call between the unpack and patch operations
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/generate_core.sh@99 
PS8, Line 99: 	sed -i -e "/\$TAR \$FLAGS \"\$(basename \"\$archive\")\"/a prepare_\${package} || exit \"\$?\"" $corescript
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/tintify_core.sh 
File payloads/external/tint/tintify_core.sh:

https://review.coreboot.org/#/c/23856/8/payloads/external/tint/tintify_core.sh@12 
PS8, Line 12: # 			<TINT_ARCHIVE_LINK> <TINT_ARCHIVE> <TINT_DIR> <TINT_CHECKSUM>
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/tintify_core.sh@54 
PS8, Line 54: echo "if [ ! -z ./\${TINT_DIR} ] && [ -e ./\${TINT_DIR}/debian ]; then" >> $tintified
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/tintify_core.sh@55 
PS8, Line 55: echo "rm -rf ./\${TINT_DIR}/debian ./\${TINT_DIR}/typedefs.h ./\${TINT_DIR}/Makefile;" >> $tintified
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/tintify_core.sh@70 
PS8, Line 70: sed -i -e "/download() {/a package=\$1\narchive_link=\"\$(eval echo \\\\\$\$package\"_ARCHIVE_LINK\")\"" $tintified
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/tintify_core.sh@72 
PS8, Line 72: sed -i -e "s/\(download_showing_percentage \"\$archive\)./\1_link\"\nreplace_plus_with_minus/g" $tintified
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/tintify_core.sh@83 
PS8, Line 83: echo "printf \"Downloaded TINT tarball ... \${green}ok\${NC}\\n\"" >> ${tintified}
line over 80 characters


https://review.coreboot.org/#/c/23856/8/payloads/external/tint/tintify_core.sh@87 
PS8, Line 87: echo "printf \"Unpacked and patched TINT... \${green}ok\${NC}\\n\"" >> ${tintified}
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/23856
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d24f222d1b92030b81bba3951e243a2a9f37290
Gerrit-Change-Number: 23856
Gerrit-PatchSet: 8
Gerrit-Owner: Mike Banon <mikebdp2 at gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Mike Banon <mikebdp2 at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 10 Dec 2018 22:06:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181210/36e20141/attachment.html>