[coreboot-gerrit] Change in ...coreboot[master]: Work in progress: Early eMMC phase 1
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Mon Dec 10 22:49:46 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30135 )
Change subject: Work in progress: Early eMMC phase 1
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30135/1/src/include/device/emmc/bh720.h
File src/include/device/emmc/bh720.h:
https://review.coreboot.org/#/c/30135/1/src/include/device/emmc/bh720.h@32
PS1, Line 32: * adress.
'adress' may be misspelled - perhaps 'address'?
https://review.coreboot.org/#/c/30135/1/src/include/device/emmc/bh720.h@37
PS1, Line 37: * Note 2: MODE_DIS_SD, MODE_VCCQ_18, MODE_POWER_SAVE, MODE_IDDQ, MODE_TUNNING,
'TUNNING' may be misspelled - perhaps 'TUNING'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/30135
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9e4f356623a00bcdd75d9ee1775ebc961807696c
Gerrit-Change-Number: 30135
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 10 Dec 2018 21:49:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181210/359a9a67/attachment.html>
More information about the coreboot-gerrit
mailing list