[coreboot-gerrit] Change in ...coreboot[master]: mb/google/octopus/var/ampton: Tune I2C Audio

Justin TerAvest (Code Review) gerrit at coreboot.org
Mon Dec 10 16:14:54 CET 2018


Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30129


Change subject: mb/google/octopus/var/ampton: Tune I2C Audio
......................................................................

mb/google/octopus/var/ampton: Tune I2C Audio

The previous settings caused the I2C frequency for the audio bus to be
too high, at 417kHz. The settings in this commit correct the frequency
to 396kHz.

BUG=b:119423345

Change-Id: Ibed886e6e1b0df4df6b87f6291e515364b3bf718
Signed-off-by: Justin TerAvest <teravest at chromium.org>
---
M src/mainboard/google/octopus/variants/ampton/overridetree.cb
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/30129/1

diff --git a/src/mainboard/google/octopus/variants/ampton/overridetree.cb b/src/mainboard/google/octopus/variants/ampton/overridetree.cb
index 46d4dcd..b3f9416 100644
--- a/src/mainboard/google/octopus/variants/ampton/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/ampton/overridetree.cb
@@ -12,8 +12,9 @@
 		},
 		.i2c[5] = {
 			.speed = I2C_SPEED_FAST,
-			.rise_time_ns = 104,
-			.fall_time_ns = 52,
+			.rise_time_ns = 60,
+			.fall_time_ns = 20,
+			.data_hold_time_ns = 350,
 		},
 		.i2c[6] = {
 			.speed = I2C_SPEED_FAST,

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30129
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibed886e6e1b0df4df6b87f6291e515364b3bf718
Gerrit-Change-Number: 30129
Gerrit-PatchSet: 1
Gerrit-Owner: Justin TerAvest <teravest at chromium.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181210/ee286063/attachment.html>


More information about the coreboot-gerrit mailing list