[coreboot-gerrit] Change in ...coreboot[master]: siemens/mc_apl4: Add GPIO configuration

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30128 )

Change subject: siemens/mc_apl4: Add GPIO configuration
......................................................................


Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/30128/2/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c 
File src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c:

https://review.coreboot.org/#/c/30128/2/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c@28 
PS2, Line 28: */
one more - sorry, I overlooked it at first


https://review.coreboot.org/#/c/30128/2/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c@141 
PS2, Line 141: */
same


https://review.coreboot.org/#/c/30128/2/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c@232 
PS2, Line 232: */
same


https://review.coreboot.org/#/c/30128/2/src/mainboard/siemens/mc_apl1/variants/mc_apl4/gpio.c@321 
PS2, Line 321: 	
Wrong syntax for a comment



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30128
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia69603f42c57c1cc682550b8eeeab42fbac27563
Gerrit-Change-Number: 30128
Gerrit-PatchSet: 2
Gerrit-Owner: Uwe Poeche <uwe.poeche at siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Uwe Poeche <uwe.poeche at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 10 Dec 2018 14:25:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181210/bb640978/attachment.html>