[coreboot-gerrit] Change in ...coreboot[master]: [WIP]pci_drivers/cpu_drivers: Fix constructed arrays on 64bit platforms

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Sun Dec 9 14:38:41 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30116 )

Change subject: [WIP]pci_drivers/cpu_drivers: Fix constructed arrays on 64bit platforms
......................................................................


Patch Set 1:

(7 comments)

https://review.coreboot.org/#/c/30116/1/src/arch/arm/include/armv7/arch/cpu.h 
File src/arch/arm/include/armv7/arch/cpu.h:

https://review.coreboot.org/#/c/30116/1/src/arch/arm/include/armv7/arch/cpu.h@30 
PS1, Line 30: } __attribute__ ((aligned (ARCH_VLA_ALIGN_SIZE)));
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/30116/1/src/arch/arm64/include/armv8/arch/cpu.h 
File src/arch/arm64/include/armv8/arch/cpu.h:

https://review.coreboot.org/#/c/30116/1/src/arch/arm64/include/armv8/arch/cpu.h@27 
PS1, Line 27: struct cpu_driver { } __attribute__ ((aligned (ARCH_VLA_ALIGN_SIZE)));
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/30116/1/src/arch/mips/include/arch/cpu.h 
File src/arch/mips/include/arch/cpu.h:

https://review.coreboot.org/#/c/30116/1/src/arch/mips/include/arch/cpu.h@29 
PS1, Line 29: } __attribute__ ((aligned (ARCH_VLA_ALIGN_SIZE)));
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/30116/1/src/arch/ppc64/include/arch/cpu.h 
File src/arch/ppc64/include/arch/cpu.h:

https://review.coreboot.org/#/c/30116/1/src/arch/ppc64/include/arch/cpu.h@28 
PS1, Line 28: } __attribute__ ((aligned (ARCH_VLA_ALIGN_SIZE)));
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/30116/1/src/arch/riscv/include/arch/cpu.h 
File src/arch/riscv/include/arch/cpu.h:

https://review.coreboot.org/#/c/30116/1/src/arch/riscv/include/arch/cpu.h@30 
PS1, Line 30: } __attribute__ ((aligned (ARCH_VLA_ALIGN_SIZE)));
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/30116/1/src/arch/x86/include/arch/cpu.h 
File src/arch/x86/include/arch/cpu.h:

https://review.coreboot.org/#/c/30116/1/src/arch/x86/include/arch/cpu.h@184 
PS1, Line 184: } __attribute__ ((aligned (ARCH_VLA_ALIGN_SIZE)));
space prohibited between function name and open parenthesis '('


https://review.coreboot.org/#/c/30116/1/src/include/device/pci.h 
File src/include/device/pci.h:

https://review.coreboot.org/#/c/30116/1/src/include/device/pci.h@58 
PS1, Line 58: } __attribute__ ((aligned (ARCH_VLA_ALIGN_SIZE)));
space prohibited between function name and open parenthesis '('



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30116
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2491d47ed03dcfd8db110dfb181b2c5281449591
Gerrit-Change-Number: 30116
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: ron minnich <rminnich at gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 09 Dec 2018 13:38:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181209/e6edd63e/attachment.html>


More information about the coreboot-gerrit mailing list