[coreboot-gerrit] Change in ...coreboot[master]: src/cpu/intel: Set get_ia32_fsb function common

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30103 )

Change subject: src/cpu/intel: Set get_ia32_fsb function common
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/30103/2/src/cpu/intel/common/fsb.c 
File src/cpu/intel/common/fsb.c:

https://review.coreboot.org/#/c/30103/2/src/cpu/intel/common/fsb.c@54 
PS2, Line 54: 0x4
> Do you want to add names here too ?
I think it is not useful to add "Netburst Model 4" here.
(same for the other cases)


https://review.coreboot.org/#/c/30103/2/src/cpu/x86/lapic/apic_timer.c 
File src/cpu/x86/lapic/apic_timer.c:

https://review.coreboot.org/#/c/30103/2/src/cpu/x86/lapic/apic_timer.c@46 
PS2, Line 46: static int set_timer_fsb(void)
            : {
            : 	car_set_var(g_timer_fsb, get_ia32_fsb());
            : 	return 0;
> return value must depend on whether g_timer_fsb is sane.
thank you so much for the review.
I'll remove "return 0".


https://review.coreboot.org/#/c/30103/2/src/include/cpu/intel/fsb.h 
File src/include/cpu/intel/fsb.h:

https://review.coreboot.org/#/c/30103/2/src/include/cpu/intel/fsb.h@17 
PS2, Line 17: get_ia32_fsb(void)
> Add description. […]
Ok, I'll do.
thank you so much for the review



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30103
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I232bf88de7ebba6ac5865db046ce79e9b2f3ed28
Gerrit-Change-Number: 30103
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 09 Dec 2018 11:36:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <siro at das-labor.org>
Comment-In-Reply-To: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181209/d7d3ab13/attachment.html>