[coreboot-gerrit] Change in ...coreboot[master]: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Modul...

David Wu (Code Review) gerrit at coreboot.org
Sat Dec 8 09:38:43 CET 2018


David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30049 )

Change subject: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Module Part Number
......................................................................


Patch Set 3:

(1 comment)

Done. Thanks.

https://review.coreboot.org/#/c/30049/2/src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex 
File src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex:

https://review.coreboot.org/#/c/30049/2/src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex@23 
PS2, Line 23: 20 20
> It looks like according to the spec these should both be 20. […]
Done



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30049
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d582b3753de9a48865eb6eca7e4fbdb31b799ff
Gerrit-Change-Number: 30049
Gerrit-PatchSet: 3
Gerrit-Owner: Lucas Chen <lucas.chen at quanta.corp-partner.google.com>
Gerrit-Reviewer: Lucas Chen <lucas.chen at quanta.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Tim Chen <tim-chen at quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: David Wu <david_wu at quanta.corp-partner.google.com>
Gerrit-Comment-Date: Sat, 08 Dec 2018 08:38:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth at google.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181208/b8a10cdc/attachment.html>


More information about the coreboot-gerrit mailing list