[coreboot-gerrit] Change in ...coreboot[master]: Work in progress: Early eMMC phase 1

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30109 )

Change subject: Work in progress: Early eMMC phase 1
......................................................................


Patch Set 1:

(13 comments)

https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c 
File src/drivers/emmc/bh7720/bh720.c:

https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@97 
PS1, Line 97: 		if(flag) {
space required before the open parenthesis '('


https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@97 
PS1, Line 97: 		if(flag) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@108 
PS1, Line 108: 		if (mode & MODE_DIS_SD) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@110 
PS1, Line 110: 		if (mode & MODE_VCCQ_18) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@112 
PS1, Line 112: 		if (mode & MODE_POWER_SAVE) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@114 
PS1, Line 114: 		if (mode & MODE_L1_TIMER) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@116 
PS1, Line 116: 		if (mode & MODE_IDDQ) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@118 
PS1, Line 118: 		if (mode & MODE_TUNNING) {
'TUNNING' may be misspelled - perhaps 'TUNING'?


https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@118 
PS1, Line 118: 		if (mode & MODE_TUNNING) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30109/1/src/drivers/emmc/bh7720/bh720.c@120 
PS1, Line 120: 		if (mode & MODE_DLL_CLK_PHASE) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30109/1/src/include/device/emmc/bh720.h 
File src/include/device/emmc/bh720.h:

https://review.coreboot.org/#/c/30109/1/src/include/device/emmc/bh720.h@35 
PS1, Line 35: #define MODE_TUNNING		BIT(6)
'TUNNING' may be misspelled - perhaps 'TUNING'?


https://review.coreboot.org/#/c/30109/1/src/include/device/emmc/bh720.h@43 
PS1, Line 43:  *      adress.
'adress' may be misspelled - perhaps 'address'?


https://review.coreboot.org/#/c/30109/1/src/include/device/emmc/bh720.h@48 
PS1, Line 48:  * Note 2: MODE_DIS_SD, MODE_VCCQ_18, MODE_POWER_SAVE, MODE_IDDQ, MODE_TUNNING,
'TUNNING' may be misspelled - perhaps 'TUNING'?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30109
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd2a307ead37c62abca811654873c43c02ac2a4a
Gerrit-Change-Number: 30109
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 07 Dec 2018 21:27:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181207/9975b821/attachment.html>