[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/lynxpoint/pcie.c: Fix a mistake in a comment

Patrick Georgi (Code Review) gerrit at coreboot.org
Fri Dec 7 12:33:21 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30078 )

Change subject: sb/intel/lynxpoint/pcie.c: Fix a mistake in a comment
......................................................................

sb/intel/lynxpoint/pcie.c: Fix a mistake in a comment

The code annotated by the comment is dealing with root port 7, so update
the comment to reflect that. It looks like the comment was copied from
the root port 3 case, but not updated.

Change-Id: I0e27e4453f4c3b2b1b9dffb0c89b71373c6b303e
Signed-off-by: Tristan Corrick <tristan at corrick.kiwi>
Reviewed-on: https://review.coreboot.org/c/30078
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Angel Pons <th3fanbus at gmail.com>
---
M src/southbridge/intel/lynxpoint/pcie.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved



diff --git a/src/southbridge/intel/lynxpoint/pcie.c b/src/southbridge/intel/lynxpoint/pcie.c
index a7966f1..70bfe18 100644
--- a/src/southbridge/intel/lynxpoint/pcie.c
+++ b/src/southbridge/intel/lynxpoint/pcie.c
@@ -395,7 +395,7 @@
 		case 7:
 			if (is_lp)
 				break;
-			/* Root Port 3 is disabled in config 11b (1x4 links). */
+			/* Root Port 7 is disabled in config 11b (1x4 links). */
 			if (((rpc.strpfusecfg2 >> 14) & 0x3) == 0x3) {
 				root_port_mark_disable(dev);
 				return;

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30078
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e27e4453f4c3b2b1b9dffb0c89b71373c6b303e
Gerrit-Change-Number: 30078
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181207/9f15a923/attachment.html>


More information about the coreboot-gerrit mailing list