[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/lynxpoint: Don't force state keep after power fail

Tristan Corrick (Code Review) gerrit at coreboot.org
Fri Dec 7 08:32:48 CET 2018


Tristan Corrick has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30101


Change subject: sb/intel/lynxpoint: Don't force state keep after power fail
......................................................................

sb/intel/lynxpoint: Don't force state keep after power fail

The deleted line crept in with commit 562db3bb3fa1 ("libpayload: find
source of input characters").

Tested on an ASRock H81M-HDS with `power_on_after_fail` set to `Disable`
via CMOS. After this patch, the system no longer powers on as soon as
power is restored after a power failure.

Change-Id: Ie9d9dab9885b285db1c5094c2c8d62aae551f1e7
Signed-off-by: Tristan Corrick <tristan at corrick.kiwi>
---
M src/southbridge/intel/lynxpoint/lpc.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/30101/1

diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c
index d914636..f0fc22d 100644
--- a/src/southbridge/intel/lynxpoint/lpc.c
+++ b/src/southbridge/intel/lynxpoint/lpc.c
@@ -199,7 +199,6 @@
 	 * If the option is not existent (Laptops), use Kconfig setting.
 	 */
 	get_option(&pwr_on, "power_on_after_fail");
-	pwr_on = MAINBOARD_POWER_KEEP;
 
 	reg16 = pci_read_config16(dev, GEN_PMCON_3);
 	reg16 &= 0xfffe;

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30101
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9d9dab9885b285db1c5094c2c8d62aae551f1e7
Gerrit-Change-Number: 30101
Gerrit-PatchSet: 1
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181207/83781846/attachment-0001.html>


More information about the coreboot-gerrit mailing list