[coreboot-gerrit] Change in ...coreboot[master]: libpayload: Don't try to use invalid row count

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30092 )

Change subject: libpayload: Don't try to use invalid row count
......................................................................


Patch Set 1:

(1 comment)

> Are you sure this is the right fix? I'd argue that a console with 0 rows is an illegal console anyway, so ...

Same sentiment here.  I'm curious where it began to leave the rails.

https://review.coreboot.org/#/c/30092/1/payloads/libpayload/drivers/video/video.c 
File payloads/libpayload/drivers/video/video.c:

https://review.coreboot.org/#/c/30092/1/payloads/libpayload/drivers/video/video.c@90 
PS1, Line 90: console->rows <= 0
Just to be complete, maybe (console->rows <= 0 || console->columns <= 0)?  Granted, it's a solution in search of a problem...



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30092
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib022d3c6fc0c9cf360809dca28761a50c787304a
Gerrit-Change-Number: 30092
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-CC: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Comment-Date: Fri, 07 Dec 2018 02:28:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181207/9f713152/attachment.html>