[coreboot-gerrit] Change in ...coreboot[master]: util/qualcomm: Add T32 debug scripts

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Dec 6 22:48:15 CET 2018


Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29951 )

Change subject: util/qualcomm: Add T32 debug scripts
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/29951/2/util/qualcomm/scripts/cmm/pbl32_to_bootblock64_jump.cmm 
File util/qualcomm/scripts/cmm/pbl32_to_bootblock64_jump.cmm:

https://review.coreboot.org/#/c/29951/2/util/qualcomm/scripts/cmm/pbl32_to_bootblock64_jump.cmm@16 
PS2, Line 16: 
are the multiple newlines near the end required? our style guide prefers us not to use such things (and that's where the Verified-1 comes from).



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e792a2806e5ebd3b4075c7bb69c43587920deae
Gerrit-Change-Number: 29951
Gerrit-PatchSet: 2
Gerrit-Owner: nsekar at codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Thu, 06 Dec 2018 21:48:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181206/0c8af201/attachment.html>


More information about the coreboot-gerrit mailing list