[coreboot-gerrit] Change in ...coreboot[master]: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Modul...

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30049 )

Change subject: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Module Part Number
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30049/1/src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex 
File src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex:

https://review.coreboot.org/#/c/30049/1/src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex@a23 
PS1, Line 23: 
            : 
Same issue here. 

0x15D Module Revision code
0x15E Manufacturer's ID, LSB
0x15F Manufacturer's ID, MSB
0x160 DRAM stepping

I'm fine with updating these bytes if appropriate, but there should be a comment in the commit message as to why.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30049
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d582b3753de9a48865eb6eca7e4fbdb31b799ff
Gerrit-Change-Number: 30049
Gerrit-PatchSet: 1
Gerrit-Owner: Lucas Chen <lucas.chen at quanta.corp-partner.google.com>
Gerrit-Reviewer: Lucas Chen <lucas.chen at quanta.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Tim Chen <tim-chen at quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 06 Dec 2018 16:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181206/da0427c0/attachment.html>