[coreboot-gerrit] Change in ...coreboot[master]: [RFC] commonlib/region: Check `xlate` regions early
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Thu Dec 6 16:27:45 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30083 )
Change subject: [RFC] commonlib/region: Check `xlate` regions early
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30083/1/src/commonlib/include/commonlib/region.h
File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/#/c/30083/1/src/commonlib/include/commonlib/region.h@88
PS1, Line 88: int (*region_ok)(const struct region_device *, const struct region *);
function definition argument 'const struct region_device *' should also have an identifier name
https://review.coreboot.org/#/c/30083/1/src/commonlib/include/commonlib/region.h@88
PS1, Line 88: int (*region_ok)(const struct region_device *, const struct region *);
function definition argument 'const struct region *' should also have an identifier name
--
To view, visit https://review.coreboot.org/c/coreboot/+/30083
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cdb9dd1ab9c00b227839a03fff389ba6fe78b4a
Gerrit-Change-Number: 30083
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 06 Dec 2018 15:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181206/ee634b8f/attachment.html>
More information about the coreboot-gerrit
mailing list