[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell: Add support for FSP MR2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29661 )

Change subject: soc/intel/braswell: Add support for FSP MR2
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> >> Am I correct that the IMAGE_REV coreboot already knows is newer? Did
> >> you ask Intel to update the version on Github?
> > 
> > No. The actual version of FSP (in 3rdparty\fsp) is MR2. To support
> > this version this patch is required.
> 
> I do understand that. Just wondering if it wouldn't be a better
> upstream solution to use the newest version everywhere.

I'm not sure about the FSP used google cyan (and variants). If a non-standard/custom FSP is used for these boards, after update FSP would be loaded.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29661
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id40b5d46ddda93845d9739b56aaf7ad24ee89246
Gerrit-Change-Number: 29661
Gerrit-PatchSet: 3
Gerrit-Owner: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks at eltan.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Thu, 06 Dec 2018 13:35:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181206/f2f71905/attachment.html>