[coreboot-gerrit] Change in ...coreboot[master]: rammus: ELAN touchpad I2C special timing requirement

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Dec 6 13:11:41 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29922 )

Change subject: rammus: ELAN touchpad I2C special timing requirement
......................................................................

rammus: ELAN touchpad I2C special timing requirement

According to issue tracker b:119899090.
https://partnerissuetracker.corp.google.com/issues/119899090

We modify rammus devicetree.cb .i2c[1] configuration to meet ELAN touchpad I2C special timing requirement.

BUG=b:119899090
BRANCH=firmware-rammus-11275.B
TEST=emerge-rammus coreboot chromeos-ec chromeos-bootimage
Flash FW to DUT, and check touchpad I2C characteristics meet requirement

Signed-off-by: YanRu chen <kane_chen at pegatron.corp-partner.google.com>
Change-Id: Ifeb08c2530e6a7674f23f7d48cefa16cfc59cb13
Reviewed-on: https://review.coreboot.org/c/29922
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/poppy/variants/rammus/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/src/mainboard/google/poppy/variants/rammus/devicetree.cb b/src/mainboard/google/poppy/variants/rammus/devicetree.cb
index f10b84d..3af712f 100644
--- a/src/mainboard/google/poppy/variants/rammus/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/rammus/devicetree.cb
@@ -191,7 +191,7 @@
 			.speed = I2C_SPEED_FAST,
 			.speed_config[0] = {
 				.speed = I2C_SPEED_FAST,
-				.scl_lcnt = 190,
+				.scl_lcnt = 170,
 				.scl_hcnt = 100,
 				.sda_hold = 36,
 			},

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29922
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifeb08c2530e6a7674f23f7d48cefa16cfc59cb13
Gerrit-Change-Number: 29922
Gerrit-PatchSet: 7
Gerrit-Owner: YanRu Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: YanRu Chen <kane_chen at pegatron.corp-partner.google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Jerry Chou <jerry_chou at pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu at pegatron.corp-partner.google.com>
Gerrit-CC: Statham Chu <statham_chu at pegatron.corp-partner.google.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181206/6227db4d/attachment.html>


More information about the coreboot-gerrit mailing list