[coreboot-gerrit] Change in ...coreboot[master]: soc/amd/stoneyridge: Get rid of device_t
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Thu Dec 6 09:27:22 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30044 )
Change subject: soc/amd/stoneyridge: Get rid of device_t
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/30044/4/src/soc/amd/stoneyridge/southbridge.c
File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/30044/4/src/soc/amd/stoneyridge/southbridge.c@712
PS4, Line 712: printk(BIOS_DEBUG, "%s\n", __func__);
code indent should use tabs where possible
https://review.coreboot.org/#/c/30044/4/src/soc/amd/stoneyridge/southbridge.c@712
PS4, Line 712: printk(BIOS_DEBUG, "%s\n", __func__);
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/30044
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d6dce29591f134f64983387c3b268019d52a602
Gerrit-Change-Number: 30044
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Thu, 06 Dec 2018 08:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181206/5f8abfb7/attachment.html>
More information about the coreboot-gerrit
mailing list