[coreboot-gerrit] Change in ...coreboot[master]: src: Get rid of "#define __SIMPLE_DEVICE__"

Arthur Heymans (Code Review) gerrit at coreboot.org
Thu Dec 6 00:51:00 CET 2018


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30040 )

Change subject: src: Get rid of "#define __SIMPLE_DEVICE__"
......................................................................


Patch Set 2:

Defining __SIMPLE_DEVICE__ is useful if you want to reuse code. Removing it only makes sense on files where __SIMPLE_DEVICES__ is already defined on all stages in which the code is linked.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30040
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4dd770fcddf44aeec847d3651ec281af5f91fbf0
Gerrit-Change-Number: 30040
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: York Yang <york.yang at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Wed, 05 Dec 2018 23:51:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181205/b3ebed1b/attachment.html>


More information about the coreboot-gerrit mailing list