[coreboot-gerrit] Change in ...coreboot[master]: Documentation/lessons/lesson2.md: fix the git push command

Marshall Dawson (Code Review) gerrit at coreboot.org
Wed Dec 5 20:21:15 CET 2018


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30054 )

Change subject: Documentation/lessons/lesson2.md: fix the git push command
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/30054/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30054/4//COMMIT_MSG@13 
PS4, Line 13: Signed-off-by: Michael Bacarella <michael.bacarella at gmail.com>
You can delete this one.


https://review.coreboot.org/#/c/30054/4/Documentation/lessons/lesson2.md 
File Documentation/lessons/lesson2.md:

https://review.coreboot.org/#/c/30054/4/Documentation/lessons/lesson2.md@146 
PS4, Line 146: git push origin HEAD:refs/for/master'
Does make gitconfig (in Part 3 above) not still run "git config remote.origin.push HEAD:refs/for/master"?  I don't see why this is necessary.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30054
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a7e58600bb1527c3e407921f7984bf94bff8d58
Gerrit-Change-Number: 30054
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Bacarella <michael.bacarella at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Comment-Date: Wed, 05 Dec 2018 19:21:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181205/5b6d0f58/attachment.html>


More information about the coreboot-gerrit mailing list