[coreboot-gerrit] Change in ...coreboot[master]: mb/lenovo/x220: Add x1 as a variant

[Bill XIE (Code Review)]

Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29434 )

Change subject: mb/lenovo/x220: Add x1 as a variant
......................................................................


Patch Set 9:

(4 comments)

https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb 
File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:

https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@79 
PS5, Line 79: 
> Thanks for clarifying, the PCH datasheet doesn't explain 'upper' and 'lower'.
Done


https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@104 
PS5, Line 104: 
> Unused pci-e ports are set to off in the newest revision.
Done


https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x1/devicetree.cb@173 
PS5, Line 173: 
> Yes, I have tried setting has_bdc_detection=1 and bdc_gpio_num=54.
Done


https://review.coreboot.org/#/c/29434/8/src/mainboard/lenovo/x220/variants/x1/overridetree.cb 
File src/mainboard/lenovo/x220/variants/x1/overridetree.cb:

https://review.coreboot.org/#/c/29434/8/src/mainboard/lenovo/x220/variants/x1/overridetree.cb@17 
PS8, Line 17: 			subsystemid 0x17aa 0x21e8
> I am just reproducing the behavior of the vendor firmware which sets them to 17aa:21e8.
Done



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc45f22c63b77ac95c188db825d0d7e2b03d2d1
Gerrit-Change-Number: 29434
Gerrit-PatchSet: 9
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 05 Dec 2018 08:15:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <siro at das-labor.org>
Comment-In-Reply-To: Bill XIE <persmule at gmail.com>
Comment-In-Reply-To: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181205/c4f9fe17/attachment.html>