[coreboot-gerrit] Change in ...coreboot[master]: mb/google/poppy/variant/nocturne: adjust RcompTarget to fix DRAM corr...

[Duncan Laurie (Code Review)]

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29361 )

Change subject: mb/google/poppy/variant/nocturne: adjust RcompTarget to fix DRAM corruption
......................................................................

mb/google/poppy/variant/nocturne: adjust RcompTarget to fix DRAM corruption

BUG=b:111812662
TEST=flash to nocturne, boot nocturne, run "memtester 1g" and
verify it passes.

Change-Id: Iefc3957f915a39a47ad6018459e65b70d1b34091
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
Reviewed-on: https://review.coreboot.org/c/29361
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Furquan Shaikh <furquan at google.com>
Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
---
M src/mainboard/google/poppy/variants/nocturne/memory.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved
  Nick Vaccaro: Looks good to me, but someone else must approve



diff --git a/src/mainboard/google/poppy/variants/nocturne/memory.c b/src/mainboard/google/poppy/variants/nocturne/memory.c
index 0b34e72..b6c77a3 100644
--- a/src/mainboard/google/poppy/variants/nocturne/memory.c
+++ b/src/mainboard/google/poppy/variants/nocturne/memory.c
@@ -33,7 +33,7 @@
 static const u16 rcomp_resistor[] = { 200, 81, 162 };
 
 /* Rcomp target */
-static const u16 rcomp_target[] = { 100, 40, 40, 23, 40 };
+static const u16 rcomp_target[] = { 100, 30, 40, 23, 40 };
 
 void variant_memory_params(struct memory_params *p)
 {

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29361
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iefc3957f915a39a47ad6018459e65b70d1b34091
Gerrit-Change-Number: 29361
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-CC: caveh jalali <caveh at chromium.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/0dde9ae2/attachment.html>