[coreboot-gerrit] Change in ...coreboot[master]: mb/google/eve: Define USB port peers

Duncan Laurie (Code Review) gerrit at coreboot.org
Tue Dec 4 23:50:33 CET 2018


Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29999 )

Change subject: mb/google/eve: Define USB port peers
......................................................................

mb/google/eve: Define USB port peers

Add ACPI _PLD group definitions for the external ports
that indicate which USB2 and USB3 ports share the same
physical interface.

Change-Id: I7f85720a878a3774d453a9adb82518722f7ba23d
Signed-off-by: Duncan Laurie <dlaurie at google.com>
Reviewed-on: https://review.coreboot.org/c/29999
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/eve/devicetree.cb
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved



diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb
index e0ef3b0..44449a5 100644
--- a/src/mainboard/google/eve/devicetree.cb
+++ b/src/mainboard/google/eve/devicetree.cb
@@ -260,6 +260,7 @@
 					chip drivers/usb/acpi
 						register "desc" = ""USB2 Type-C Left""
 						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
 						device usb 2.0 on end
 					end
 					chip drivers/usb/acpi
@@ -275,6 +276,7 @@
 					chip drivers/usb/acpi
 						register "desc" = ""USB2 Type-C Right""
 						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(2, 1)"
 						device usb 2.4 on end
 					end
 					chip drivers/usb/acpi
@@ -285,11 +287,13 @@
 					chip drivers/usb/acpi
 						register "desc" = ""USB3 Type-C Left""
 						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
 						device usb 3.0 on end
 					end
 					chip drivers/usb/acpi
 						register "desc" = ""USB3 Type-C Right""
 						register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(2, 1)"
 						device usb 3.1 on end
 					end
 				end

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29999
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f85720a878a3774d453a9adb82518722f7ba23d
Gerrit-Change-Number: 29999
Gerrit-PatchSet: 6
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/ec032b51/attachment.html>


More information about the coreboot-gerrit mailing list