[coreboot-gerrit] Change in ...coreboot[master]: Documentation/../../kblrvp11: Add RVP11 documentation

Patrick Rudolph (Code Review) gerrit at coreboot.org
Tue Dec 4 16:34:42 CET 2018


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29859 )

Change subject: Documentation/../../kblrvp11: Add RVP11 documentation
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

https://review.coreboot.org/#/c/29859/2/Documentation/mainboard/intel/kblrvp11.md 
File Documentation/mainboard/intel/kblrvp11.md:

https://review.coreboot.org/#/c/29859/2/Documentation/mainboard/intel/kblrvp11.md@48 
PS2, Line 48: 1. Dediprog SF600 with adapter B is used.
Not everyboard has a dediprog, I'd recommend to just reference https://doc.coreboot.org/flash_tutorial/index.html


https://review.coreboot.org/#/c/29859/2/Documentation/mainboard/intel/kblrvp11.md@50 
PS2, Line 50: 3. Connect Dediprog SF600 to header at J7H1.
That's the important part here.
Knowing that there's a programming header compatible to dediprog pinout.


https://review.coreboot.org/#/c/29859/2/Documentation/mainboard/intel/kblrvp11.md@52 
PS2, Line 52: 5. Go to "file" and select the .rom file (16 MB) to program chip1.
That seems to describe some Windows UI ?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29859
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01509c2fa2c127b77ae72b8b0aaac0f826b0bedd
Gerrit-Change-Number: 29859
Gerrit-PatchSet: 2
Gerrit-Owner: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Teo Boon Tiong <boon.tiong.teo at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 04 Dec 2018 15:34:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/b6b72736/attachment.html>


More information about the coreboot-gerrit mailing list