[coreboot-gerrit] Change in ...coreboot[master]: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )

Change subject: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant
......................................................................


Patch Set 9:

(2 comments)

> Patch Set 8:
> 
> (2 comments)
> 
> > Patch Set 8:
> > 
> > (4 comments)
> > 
> > Do you want to add a data.vbt file ?
> 
> How? Can it be dumped someway? Currently using that for T430s seems working.

You can use intelvbttool to extract it from VGA Option Rom.

https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/romstage.c 
File src/mainboard/lenovo/t430s/variants/t431s/romstage.c:

https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/romstage.c@37 
PS8, Line 37: 	pci_write_config32(PCH_LPC_DEV, LPC_GEN4_DEC, 0x0c06a1);
> They are different in the last line of this function.
There's no COM1 or COM2, so setting IO_DEC is a bit pointless.
IMHO this should always be done in chipset code.


https://review.coreboot.org/#/c/30021/8/src/mainboard/lenovo/t430s/variants/t431s/romstage.c@37 
PS8, Line 37: pci
No need to write it here, only if you want to access io range 0x6a0 in romstage.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a
Gerrit-Change-Number: 30021
Gerrit-PatchSet: 9
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Comment-Date: Tue, 04 Dec 2018 10:33:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph at 9elements.com>
Comment-In-Reply-To: Bill XIE <persmule at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/91377ef0/attachment.html>