[coreboot-gerrit] Change in ...coreboot[master]: Documentation: Clarify minor detail on preparing a layout file

Patrick Georgi (Code Review) gerrit at coreboot.org
Tue Dec 4 11:25:53 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30024 )

Change subject: Documentation: Clarify minor detail on preparing a layout file
......................................................................

Documentation: Clarify minor detail on preparing a layout file

The user needs to pass the original firmware image to create
a layout file, not the newly compiled coreboot image.

Signed-off-by: Michael Bacarella <michael.bacarella at gmail.com>
Change-Id: If47a88f06076da12d8da7a873c3e5ef64fc1f877
Reviewed-on: https://review.coreboot.org/c/30024
Reviewed-by: Angel Pons <th3fanbus at gmail.com>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M Documentation/flash_tutorial/index.md
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Angel Pons: Looks good to me, approved



diff --git a/Documentation/flash_tutorial/index.md b/Documentation/flash_tutorial/index.md
index 1a29137..eb74ad0 100644
--- a/Documentation/flash_tutorial/index.md
+++ b/Documentation/flash_tutorial/index.md
@@ -68,10 +68,11 @@
 to write only a part of the flash IC. On Intel for example there are IFD, ME and
 GBE which don't need to be updated to install coreboot.
 To make [flashrom] only write the *bios* region, leaving Intel ME and Intel IFD
-untouched, you can use a layout file, which can be created using ifdtool
+untouched, you can use a layout file, which can be created with ifdtool and a backup
+of the original firmware.
 
 ```bash
-ifdtool -f rom.layout coreboot.rom
+ifdtool -f rom.layout backup.rom
 ```
 
 and looks similar to:

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If47a88f06076da12d8da7a873c3e5ef64fc1f877
Gerrit-Change-Number: 30024
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bacarella <michael.bacarella at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/dfa181c1/attachment.html>


More information about the coreboot-gerrit mailing list