[coreboot-gerrit] Change in ...coreboot[master]: ec/google/wilco: Enable COM1 ACPI device

Patrick Georgi (Code Review) gerrit at coreboot.org
Tue Dec 4 11:17:27 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29672 )

Change subject: ec/google/wilco: Enable COM1 ACPI device
......................................................................

ec/google/wilco: Enable COM1 ACPI device

Enable the COM1 ACPI device based on the existing Kconfig option
CONFIG_DRIVERS_UART_8250IO instead of expecting the mainboard to
also define another value for ACPI.

Change-Id: I69361cc2c245cfcad3e4f57567bf56d5a26f0b06
Signed-off-by: Duncan Laurie <dlaurie at google.com>
Reviewed-on: https://review.coreboot.org/c/29672
Reviewed-by: Furquan Shaikh <furquan at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/ec/google/wilco/acpi/superio.asl
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved



diff --git a/src/ec/google/wilco/acpi/superio.asl b/src/ec/google/wilco/acpi/superio.asl
index a8cea78..9c23c49 100644
--- a/src/ec/google/wilco/acpi/superio.asl
+++ b/src/ec/google/wilco/acpi/superio.asl
@@ -29,7 +29,7 @@
 
 		Method (_STA, 0, NotSerialized)
 		{
-#ifdef SIO_EC_ENABLE_COM1
+#if IS_ENABLED(CONFIG_DRIVERS_UART_8250IO)
 			Return (0x0f)
 #else
 			Return (Zero)

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29672
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69361cc2c245cfcad3e4f57567bf56d5a26f0b06
Gerrit-Change-Number: 29672
Gerrit-PatchSet: 4
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/4df1a126/attachment.html>


More information about the coreboot-gerrit mailing list