[coreboot-gerrit] Change in ...coreboot[master]: Documentation/mainboard/lenovo/t420.md: add pic of chip

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30027 )

Change subject: Documentation/mainboard/lenovo/t420.md: add pic of chip
......................................................................


Patch Set 1: Code-Review+1

IMHO, it's worth to mention that GND is connected to various points such as mounting holes and connector shells. That way, to know where GND is on the chip, one could just measure the resistance from the pins to GND with an ohmeter. The correct pin would show minimal resistance.

Other than that, and what Patrick mentioned, this looks good to me. (other than my OCD complaining about how dirty the mainboard is :P)


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30027
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9046fa63dcd4d192836417efac68ca7587ac1c91
Gerrit-Change-Number: 30027
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bacarella <michael.bacarella at gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 04 Dec 2018 07:08:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181204/bd7e3dee/attachment.html>