[coreboot-gerrit] Change in ...coreboot[master]: src: Don't use device_t

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Dec 3 22:04:29 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30004 )

Change subject: src: Don't use device_t
......................................................................


Patch Set 5:

(6 comments)

https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h 
File src/southbridge/amd/sr5650/cmn.h:

https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@185 
PS5, Line 185: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@217 
PS5, Line 217: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@229 
PS5, Line 229: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@241 
PS5, Line 241: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@253 
PS5, Line 253: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/30004/5/src/southbridge/amd/sr5650/cmn.h@265 
PS5, Line 265: 	if (reg != reg_old) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic29891d78514db3b7eed48414a14e4ff579436c0
Gerrit-Change-Number: 30004
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 03 Dec 2018 21:04:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/3a6be49d/attachment.html>


More information about the coreboot-gerrit mailing list