[coreboot-gerrit] Change in ...coreboot[master]: cpu/intel/fsp_model_406dx: Drop dead microcode reference

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Dec 3 14:40:49 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29931 )

Change subject: cpu/intel/fsp_model_406dx: Drop dead microcode reference
......................................................................

cpu/intel/fsp_model_406dx: Drop dead microcode reference

The referenced Kconfig symbols don't exist (anymore?).

Change-Id: Ia724262a526fe960c17ae4b248acfa42fc342331
Signed-off-by: Nico Huber <nico.huber at secunet.com>
Reviewed-on: https://review.coreboot.org/c/29931
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: David Guckian
Reviewed-by: Angel Pons <th3fanbus at gmail.com>
---
M src/cpu/intel/fsp_model_406dx/Makefile.inc
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  David Guckian: Looks good to me, but someone else must approve



diff --git a/src/cpu/intel/fsp_model_406dx/Makefile.inc b/src/cpu/intel/fsp_model_406dx/Makefile.inc
index d82ddd6..26f4633 100644
--- a/src/cpu/intel/fsp_model_406dx/Makefile.inc
+++ b/src/cpu/intel/fsp_model_406dx/Makefile.inc
@@ -19,8 +19,4 @@
 
 ramstage-y += acpi.c
 
-ifeq ($(CONFIG_HAVE_CPU_MICROCODE_FILE), y)
-cpu_microcode_bins += $(call strip_quotes,$(CONFIG_CPU_MICROCODE_FILE))
-endif
-
 CPPFLAGS_romstage += -I$(src)/cpu/intel/fsp_model_406dx

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia724262a526fe960c17ae4b248acfa42fc342331
Gerrit-Change-Number: 29931
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: Fei Wang
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/01fd7c2b/attachment.html>


More information about the coreboot-gerrit mailing list