[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/lynxpoint: Ensure the finalise handler is called

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Dec 3 14:13:12 CET 2018


Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29976 )

Change subject: sb/intel/lynxpoint: Ensure the finalise handler is called
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> (1 comment)
> 
> Patrick G., not sure if anybody @google still cares, but it seems like
> Lynx Point was missing the finalize trigger on the resume path all the
> time.

Thanks for the heads-up, but I don't think we ever used INTEL_CHIPSET_LOCKDOWN in the first place, so ¯\_(ツ)_/¯ ?


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29976
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9766a8dcbcb38420e937c810d252fef071851e92
Gerrit-Change-Number: 29976
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 03 Dec 2018 13:13:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/de38a991/attachment.html>


More information about the coreboot-gerrit mailing list