[coreboot-gerrit] Change in ...coreboot[master]: include/device/smbus.h: Don't use device_t
Patrick Georgi (Code Review)
gerrit at coreboot.org
Mon Dec 3 14:01:17 CET 2018
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29914 )
Change subject: include/device/smbus.h: Don't use device_t
......................................................................
include/device/smbus.h: Don't use device_t
Use of device_t is deprecated.
Change-Id: I2c88642133d3cbf33015e3e1e855fb2c786878d6
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/c/29914
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/include/device/smbus.h
1 file changed, 9 insertions(+), 8 deletions(-)
Approvals:
build bot (Jenkins): Verified
Patrick Georgi: Looks good to me, approved
diff --git a/src/include/device/smbus.h b/src/include/device/smbus.h
index 50857fe..639e938 100644
--- a/src/include/device/smbus.h
+++ b/src/include/device/smbus.h
@@ -8,12 +8,13 @@
/* Common SMBus bus operations */
struct smbus_bus_operations {
- int (*recv_byte)(device_t dev);
- int (*send_byte)(device_t dev, u8 value);
- int (*read_byte)(device_t dev, u8 addr);
- int (*write_byte)(device_t dev, u8 addr, u8 value);
- int (*block_read)(device_t dev, u8 cmd, u8 bytes, u8 *buffer);
- int (*block_write)(device_t dev, u8 cmd, u8 bytes, const u8 *buffer);
+ int (*recv_byte)(struct device *dev);
+ int (*send_byte)(struct device *dev, u8 value);
+ int (*read_byte)(struct device *dev, u8 addr);
+ int (*write_byte)(struct device *dev, u8 addr, u8 value);
+ int (*block_read)(struct device *dev, u8 cmd, u8 bytes, u8 *buffer);
+ int (*block_write)(struct device *dev, u8 cmd, u8 bytes,
+ const u8 *buffer);
};
static inline const struct smbus_bus_operations *ops_smbus_bus(struct bus *bus)
@@ -27,8 +28,8 @@
return bops;
}
-struct bus *get_pbus_smbus(device_t dev);
-int smbus_set_link(device_t dev);
+struct bus *get_pbus_smbus(struct device *dev);
+int smbus_set_link(struct device *dev);
static inline int smbus_recv_byte(struct device *const dev)
{
--
To view, visit https://review.coreboot.org/c/coreboot/+/29914
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c88642133d3cbf33015e3e1e855fb2c786878d6
Gerrit-Change-Number: 29914
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/7cab73d4/attachment.html>
More information about the coreboot-gerrit
mailing list