[coreboot-gerrit] Change in ...coreboot[master]: mainboard/lenovo: Add ThinkPad T431s

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Dec 3 13:59:13 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )

Change subject: mainboard/lenovo: Add ThinkPad T431s
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/30021/5/src/mainboard/lenovo/t431s/smihandler.c 
File src/mainboard/lenovo/t431s/smihandler.c:

https://review.coreboot.org/#/c/30021/5/src/mainboard/lenovo/t431s/smihandler.c@61 
PS5, Line 61: 		pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value - 0x10) & 0xf0);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a
Gerrit-Change-Number: 30021
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 03 Dec 2018 12:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/5a45bf3b/attachment.html>


More information about the coreboot-gerrit mailing list