[coreboot-gerrit] Change in ...coreboot[master]: mainboard/lenovo: Add ThinkPad T431s

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )

Change subject: mainboard/lenovo: Add ThinkPad T431s
......................................................................


Patch Set 4:

(5 comments)

https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandler.c 
File src/mainboard/lenovo/t431s/smihandler.c:

https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandler.c@52 
PS4, Line 52: 	if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
do not use assignment in if condition


https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandler.c@60 
PS4, Line 60: 	if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
do not use assignment in if condition


https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandler.c@76 
PS4, Line 76: 	switch (event) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandler.c@98 
PS4, Line 98: 	switch (data) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/30021/4/src/mainboard/lenovo/t431s/smihandler.c@108 
PS4, Line 108: 			/* we have to use port 0x62/0x66, as 0x1600/0x1604 doesn't
line over 80 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8062cacf5e8232405bb5757e1b1d063541f354a
Gerrit-Change-Number: 30021
Gerrit-PatchSet: 4
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 03 Dec 2018 12:52:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/1a1ae724/attachment.html>