[coreboot-gerrit] Change in ...coreboot[master]: mb/google/sarien: Enable WWAN detection

Amanda Hwang (Code Review) gerrit at coreboot.org
Mon Dec 3 11:07:28 CET 2018


Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30017


Change subject: mb/google/sarien: Enable WWAN detection
......................................................................

mb/google/sarien: Enable WWAN detection

Set WWAN_GPIO_PERST#(GPP_D22) to low at bootblock stage to meet
the logic output for WWAN_PERST#_R to high.

BUG=120004153
TEST=Boot up Sarien board, check WWAN get detected as USB
devices through lsusb.

Change-Id: I16f1101c64dfd4dcb5e8342fdb925951f6f2f90b
Signed-off-by: Amanda Huang <amanda_hwang at compal.corp-partner.google.com>
---
M src/mainboard/google/sarien/variants/sarien/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/30017/1

diff --git a/src/mainboard/google/sarien/variants/sarien/gpio.c b/src/mainboard/google/sarien/variants/sarien/gpio.c
index 31b42ef..a41d940 100644
--- a/src/mainboard/google/sarien/variants/sarien/gpio.c
+++ b/src/mainboard/google/sarien/variants/sarien/gpio.c
@@ -121,7 +121,7 @@
 /* DMIC_CLK0 */		PAD_NC(GPP_D19, NONE),
 /* DMIC_DATA0 */	PAD_NC(GPP_D20, NONE),
 /* SPI1_IO2 */		PAD_CFG_GPO(GPP_D21, 1, DEEP), /* WWAN_BB_RST# */
-/* SPI1_IO3 */		PAD_CFG_GPO(GPP_D22, 1, DEEP), /* WWAN_GPIO_PERST# */
+/* SPI1_IO3 */		PAD_CFG_GPO(GPP_D22, 0, DEEP), /* WWAN_GPIO_PERST# */
 /* I2S_MCLK */		PAD_CFG_GPI_SCI_LOW(GPP_D23, NONE, DEEP,
 				 EDGE_SINGLE), /* WWAN_GPIO_WAKE# */
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30017
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16f1101c64dfd4dcb5e8342fdb925951f6f2f90b
Gerrit-Change-Number: 30017
Gerrit-PatchSet: 1
Gerrit-Owner: Amanda Hwang <amanda_hwang at compal.corp-partner.google.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/c833acc5/attachment.html>


More information about the coreboot-gerrit mailing list