[coreboot-gerrit] Change in ...coreboot[master]: cbmem: Enable AArch64 support

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Mon Dec 3 10:43:04 CET 2018


Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29978 )

Change subject: cbmem: Enable AArch64 support
......................................................................

cbmem: Enable AArch64 support

TEST=on Chromebook Kevin with 64bit userland, it works well.

Change-Id: If16065000214c6cff9c14a14c5b5f44faca38153
Signed-off-by: Adam Kallai <kadam at inf.u-szeged.hu>
Reviewed-on: https://review.coreboot.org/c/29978
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Julius Werner <jwerner at chromium.org>
---
M util/cbmem/cbmem.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved



diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c
index 90ad55e..8e73d9c 100644
--- a/util/cbmem/cbmem.c
+++ b/util/cbmem/cbmem.c
@@ -1123,7 +1123,7 @@
 	exit(exit_code);
 }
 
-#ifdef __arm__
+#if defined(__arm__) || defined(__aarch64__)
 static void dt_update_cells(const char *name, int *addr_cells_ptr,
 			    int *size_cells_ptr)
 {
@@ -1236,7 +1236,7 @@
 	closedir(dir);
 	return ret;
 }
-#endif /* __arm__ */
+#endif /* defined(__arm__) || defined(__aarch64__) */
 
 int main(int argc, char** argv)
 {
@@ -1339,7 +1339,7 @@
 		return 1;
 	}
 
-#ifdef __arm__
+#if defined(__arm__) || defined(__aarch64__)
 	int addr_cells, size_cells;
 	char *coreboot_node = dt_find_compat("/proc/device-tree", "coreboot",
 					     &addr_cells, &size_cells);

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29978
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If16065000214c6cff9c14a14c5b5f44faca38153
Gerrit-Change-Number: 29978
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Kallai <kadam at inf.u-szeged.hu>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: Ádám Kallai <kadam at inf.u-szeged.hu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/d9960080/attachment.html>


More information about the coreboot-gerrit mailing list