[coreboot-gerrit] Change in ...coreboot[master]: riscv: add support to select the privilege level of the payload running

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Dec 3 05:18:31 CET 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29494 )

Change subject: riscv: add support to select the privilege level of the payload running
......................................................................


Patch Set 19:

(1 comment)

https://review.coreboot.org/#/c/29494/19/src/arch/riscv/boot.c 
File src/arch/riscv/boot.c:

https://review.coreboot.org/#/c/29494/19/src/arch/riscv/boot.c@46 
PS19, Line 46: 		void (*doit)(void *) = prog_entry(prog);
function definition argument 'void *' should also have an identifier name



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29494
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96961246cd257b63cf167238aa0cf6e65272b951
Gerrit-Change-Number: 29494
Gerrit-PatchSet: 19
Gerrit-Owner: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Hug <philipp at hug.cx>
Gerrit-Reviewer: Shawn Chang <citypw at gmail.com>
Gerrit-Reviewer: Xiang Wang <wxjstz at 126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich at gmail.com>
Gerrit-Comment-Date: Mon, 03 Dec 2018 04:18:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/8f600d43/attachment.html>


More information about the coreboot-gerrit mailing list