[coreboot-gerrit] Change in ...coreboot[master]: mb/google/sarien/variants/sarien: Enable melf touchscreen

[Chris Zhou (Code Review)]

Chris Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29830 )

Change subject: mb/google/sarien/variants/sarien: Enable melf touchscreen
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/29830/2/src/mainboard/google/sarien/variants/sarien/devicetree.cb 
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:

https://review.coreboot.org/#/c/29830/2/src/mainboard/google/sarien/variants/sarien/devicetree.cb@124 
PS2, Line 124: GPP_B13
> This pin is going to get pulsed by the kernel when sequencing power to the touchscreen, and we don't […]
Do we need to change the schematic? or remove the reset GPIO setting?
Do you have any suggestion?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29830
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I926c988c141628ae2d98206f9eb615d06357a366
Gerrit-Change-Number: 29830
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
Gerrit-Reviewer: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Crystal Lin <crystal_lin at compal.corp-partner.google.com>
Gerrit-CC: Duncan Laurie <dlaurie at chromium.org>
Gerrit-CC: Ivy Jian <ivy_jian at compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen at compal.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 03 Dec 2018 03:38:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chris Zhou <chris_zhou at compal.corp-partner.google.com>
Comment-In-Reply-To: Duncan Laurie <dlaurie at chromium.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181203/2b8852b9/attachment.html>