[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/lynxpoint/pch.c: Don't use device_t

HAOUAS Elyes (Code Review) gerrit at coreboot.org
Sun Dec 2 20:08:27 CET 2018


HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30005


Change subject: sb/intel/lynxpoint/pch.c: Don't use device_t
......................................................................

sb/intel/lynxpoint/pch.c: Don't use device_t

Use of device_t is deprecated.

Change-Id: I3badd64d9ce8148c740d33c31ae599a3fcd363f1
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/southbridge/intel/lynxpoint/pch.c
1 file changed, 8 insertions(+), 5 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/30005/1

diff --git a/src/southbridge/intel/lynxpoint/pch.c b/src/southbridge/intel/lynxpoint/pch.c
index cb01de7..6596aa2 100644
--- a/src/southbridge/intel/lynxpoint/pch.c
+++ b/src/southbridge/intel/lynxpoint/pch.c
@@ -23,14 +23,17 @@
 #include <device/pci_def.h>
 #include "pch.h"
 
-static device_t pch_get_lpc_device(void)
+#ifdef __SIMPLE_DEVICE__
+static pci_devfn_t pch_get_lpc_device(void)
 {
-#ifdef __SMM__
 	return PCI_DEV(0, 0x1f, 0);
-#else
-	return dev_find_slot(0, PCI_DEVFN(0x1f, 0));
-#endif
 }
+#else
+static struct device *pch_get_lpc_device(void)
+{
+	return dev_find_slot(0, PCI_DEVFN(0x1f, 0));
+}
+#endif
 
 int pch_silicon_revision(void)
 {

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30005
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3badd64d9ce8148c740d33c31ae599a3fcd363f1
Gerrit-Change-Number: 30005
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181202/b5835f3d/attachment.html>


More information about the coreboot-gerrit mailing list