[coreboot-gerrit] Change in ...coreboot[master]: sb/{bd82x6x, i82801gx, ibexpeak, lynxpoint}: Use BIOS_CNTL macro

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29990 )

Change subject: sb/{bd82x6x,i82801gx,ibexpeak,lynxpoint}: Use BIOS_CNTL macro
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/29990/1/src/southbridge/intel/i82801gx/lpc.c 
File src/southbridge/intel/i82801gx/lpc.c:

https://review.coreboot.org/#/c/29990/1/src/southbridge/intel/i82801gx/lpc.c@358 
PS1, Line 358: #if TEST_SMM_FLASH_LOCKDOWN
> is this dead code ?
indeed, TEST_SMM_FLASH_LOCKDOWN is defined as zero.
for my understanding, this is used for test/debug purpose.

I can remove it if there is no objection.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d2b555ada9c2893af4f85422128f5a8b04e2fc6
Gerrit-Change-Number: 29990
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 02 Dec 2018 16:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181202/cc78b63a/attachment.html>