[coreboot-gerrit] Change in ...coreboot[master]: src: Remove unused variables

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29917 )

Change subject: src: Remove unused variables
......................................................................


Patch Set 14:

(2 comments)

https://review.coreboot.org/#/c/29917/14//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/29917/14//COMMIT_MSG@7 
PS14, Line 7: src: Remove unused variables
> why did you fix it ? […]
AFAIK, that is the idea. It should also improve code quality.
"Should".


https://review.coreboot.org/#/c/29917/14/src/southbridge/intel/fsp_rangeley/romstage.c 
File src/southbridge/intel/fsp_rangeley/romstage.c:

https://review.coreboot.org/#/c/29917/14/src/southbridge/intel/fsp_rangeley/romstage.c@123 
PS14, Line 123: 		printk(BIOS_DEBUG, "cbmem was initted\n");
> good solution, but I only care about the error case. […]
Is the cbmem_was_initted variable needed though? cbmem_recovery could be called from within the if():

if(cbmem_recovery(0)) printk(BIOS_ERR, "whatever");



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdfbf1031130ff861c4313d1271d6ccb68bf8837
Gerrit-Change-Number: 29917
Gerrit-PatchSet: 14
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Damien Zammit <damien at zamaudio.com>
Gerrit-Reviewer: David Guckian <david.guckian at intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-Reviewer: Huang Jin <huang.jin at intel.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: York Yang <york.yang at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 02 Dec 2018 09:28:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <siro at das-labor.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181202/b90a59ed/attachment.html>